Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not clear cookies when bearer token does not match to avoid auto logouts #2854

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

alex-kovoy
Copy link
Contributor

This partially addresses this issue https://github.com/gravitational/gravity.e/issues/4165 + some clean up as this line does not bring additional security properties.

Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine since an error is still returned, can you also create a ticket so it doesn't return 401 during bearer token rotation?

@alex-kovoy alex-kovoy force-pushed the alexey/clearsession branch from 00e6d24 to c2d6a26 Compare July 12, 2019 13:14
@alex-kovoy alex-kovoy force-pushed the alexey/clearsession branch from c2d6a26 to 3e2a428 Compare July 12, 2019 13:39
@alex-kovoy
Copy link
Contributor Author

Sure, here is a separate ticket for that #2856

@alex-kovoy alex-kovoy merged commit 784f8f5 into master Jul 12, 2019
@alex-kovoy alex-kovoy deleted the alexey/clearsession branch July 12, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants